ObjectLink ( )

Pertex
11 Jan 2012, 12:36ObjectLink creates a hyperlink with the display verbs of the object. Its possible so far to create objectlinks with other verbs with
Would it be possible to enhance the ObjectLink function to do the same? Something like
<object verbs='dig/scream'>room</object>
Would it be possible to enhance the ObjectLink function to do the same? Something like
ObjectLink ( object, "eat/throw/resize")
Alex
11 Jan 2012, 12:45Could do... the power is all yours, the ObjectLink function is in the Core library
- would love to start getting some more pull requests!


Pertex
11 Jan 2012, 13:03Its not a problem to do this in the function library. Its a (my) problem to add this to the gui. And I still not know how to send a pull request 

Alex
11 Jan 2012, 13:14ObjectLink doesn't appear anywhere in the GUI anyway.
Pull requests should be pretty simple, you just check in to your own fork (first, check in on your own machine, then push your changes to your own fork on CodePlex). Then when you're ready, send the Pull Request.
Pull requests should be pretty simple, you just check in to your own fork (first, check in on your own machine, then push your changes to your own fork on CodePlex). Then when you're ready, send the Pull Request.

Pertex
11 Jan 2012, 13:24Pretty simple? No, I am always in panic if I must work with tortoisehg. And I didnt manage it to create a pull request, I didnt even find the option to do this in tortoisehg. I deleted my fork on my PC, so you could delete this fork on Codeplex, too.
Alex
11 Jan 2012, 13:43You send the Pull Request from CodePlex.
When you create a fork, you're creating a new repository on CodePlex, basically a copy of the main Quest one. You create the fork using the CodePlex site, and then CodePlex gives you a URL you can put into TortoiseHg.
You then check out the fork on your own machine using TortoiseHg. Unlike SVN you get a copy of the whole repository including all the history. You now have a copy of the repository running locally on your machine.
You make your changes and then check in to your local machine, using TortoiseHg. Next, you "push" those changes back up to your fork on CodePlex, again using TortoiseHg.
Once you've done this, you can request that I transfer the changes you've made - from: your copy of the Quest repository, to: the main Quest repository. This is the Pull Request, and you do this on the CodePlex site.
There's nothing special about the Pull Request really. CodePlex lets me see all forks anyway, so any changes you've pushed to CodePlex are visible to me. The Pull Request is just a formal way of letting me know that you're ready with your changes, and you think it's time for me to transfer them into the main repository.
Hope that makes some kind of sense!
When you create a fork, you're creating a new repository on CodePlex, basically a copy of the main Quest one. You create the fork using the CodePlex site, and then CodePlex gives you a URL you can put into TortoiseHg.
You then check out the fork on your own machine using TortoiseHg. Unlike SVN you get a copy of the whole repository including all the history. You now have a copy of the repository running locally on your machine.
You make your changes and then check in to your local machine, using TortoiseHg. Next, you "push" those changes back up to your fork on CodePlex, again using TortoiseHg.
Once you've done this, you can request that I transfer the changes you've made - from: your copy of the Quest repository, to: the main Quest repository. This is the Pull Request, and you do this on the CodePlex site.
There's nothing special about the Pull Request really. CodePlex lets me see all forks anyway, so any changes you've pushed to CodePlex are visible to me. The Pull Request is just a formal way of letting me know that you're ready with your changes, and you think it's time for me to transfer them into the main repository.
Hope that makes some kind of sense!

Pertex
11 Jan 2012, 17:10I hate it. I did as you said but it seems to push it to the main repo. When pushing the file, it says it would be push it into my fork 

Alex
11 Jan 2012, 17:21Make sure you do your edits on your fork - not the code you have checked out from main repo. You need to check out your fork separately - it has a separate URL.
I've removed your permissions from the main repo so at least you'll get an error message now
For now, I've backed out the change you pushed to the main repo. I think a better way to implement that feature may be to re-add what was there a while ago, which was to update the "lookat" template so that (?<object>) would match (although this would mean rewriting the "lookat" template so that it was not a verbtemplate). But I'll have a look in more detail when I look at the pull request properly.
I've removed your permissions from the main repo so at least you'll get an error message now

For now, I've backed out the change you pushed to the main repo. I think a better way to implement that feature may be to re-add what was there a while ago, which was to update the "lookat" template so that (?<object>) would match (although this would mean rewriting the "lookat" template so that it was not a verbtemplate). But I'll have a look in more detail when I look at the pull request properly.

Pertex
11 Jan 2012, 21:07Alex wrote:For now, I've backed out the change you pushed to the main repo. I think a better way to implement that feature may be to re-add what was there a while ago, which was to update the "lookat" template so that (?<object>) would match (although this would mean rewriting the "lookat" template so that it was not a verbtemplate). But I'll have a look in more detail when I look at the pull request properly.
Perhaps you could have a look at the other thing, too, that if you just press enter without text Q5 reprints the roomdescription? That would be nice
